vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: kanban-card mutatation violation #712

Merged
konrad merged 1 commits from dpschen/frontend:feature/fix-KanbanCard-mutation-violation into main 2021-09-08 16:28:14 +00:00
Conversation 0 Commits 1 Files Changed 1 +4 -2
dpschen commented 2021-09-08 10:20:21 +00:00
Member
Copy Link

By updating the done value directly this violates the vue pattern props down and events up and thus prevents further errors.
Instead we create a new task object and dispatch that instead.

By updating the done value directly this violates the vue pattern props down and events up and thus prevents further errors. Instead we create a new task object and dispatch that instead.
dpschen added 1 commit 2021-09-08 10:20:22 +00:00
continuous-integration/drone/pr Build is passing Details
13b6f0cad9
fix: kanban-card mutatation violation
konrad approved these changes 2021-09-08 16:27:55 +00:00
konrad left a comment
Owner

Nice catch!

Nice catch!
konrad merged commit 4fc8858c64 into main 2021-09-08 16:28:14 +00:00
konrad deleted branch feature/fix-KanbanCard-mutation-violation 2021-09-08 16:28:14 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#712
No description provided.
Delete Branch "dpschen/frontend:feature/fix-KanbanCard-mutation-violation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?