vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

chore: make method event independent #719

Merged
konrad merged 1 commits from dpschen/frontend:feature/checkbox_make-method-event-independent into main 2021-09-09 22:25:08 +00:00
Conversation 6 Commits 1 Files Changed 1 +5 -5
dpschen commented 2021-09-08 13:50:52 +00:00
Member
Copy Link
No description provided.
dpschen changed title from chore: make method event independent to WIP: chore: make method event independent 2021-09-08 16:31:39 +00:00
dpschen changed title from WIP: chore: make method event independent to chore: make method event independent 2021-09-08 16:44:17 +00:00
dpschen commented 2021-09-08 16:46:14 +00:00
Author
Member
Copy Link

@konrad Not sure why this fails. any idea?
How can I repeat the build without committing again?

@konrad Not sure why this fails. any idea? How can I repeat the build without committing again?
konrad commented 2021-09-08 17:01:08 +00:00
Owner
Copy Link

Don't know either - restarted. Seems to work now.

Don't know either - restarted. Seems to work now.
👍 1
konrad commented 2021-09-08 21:47:16 +00:00
Owner
Copy Link

Okay looks like it does not work. The test that's failing is testing a component that uses the fancycheckbox component. Looks like this PR broke something in it.

Okay looks like it does not work. The test that's failing is testing a component that uses the fancycheckbox component. Looks like this PR broke something in it.
dpschen changed title from chore: make method event independent to wip: chore: make method event independent 2021-09-08 22:16:52 +00:00
dpschen commented 2021-09-08 22:17:40 +00:00
Author
Member
Copy Link

Yes… I thought something with the pipeline was broken, but seems like the branch aswell. Will investigate.

Yes… I thought something with the pipeline was broken, but seems like the branch aswell. Will investigate.
dpschen force-pushed feature/checkbox_make-method-event-independent from 12b71e6de7 to f01fb21134 2021-09-08 22:35:45 +00:00 Compare
dpschen commented 2021-09-08 22:36:46 +00:00
Author
Member
Copy Link

Hahaha,
I used event.target.value instead of event.target.checked... I guess that was it.

Hahaha, I used `event.target.value` instead of `event.target.checked`... I guess that was it.
dpschen changed title from wip: chore: make method event independent to chore: make method event independent 2021-09-08 22:41:07 +00:00
konrad commented 2021-09-09 22:25:03 +00:00
Owner
Copy Link

Thanks!

Thanks!
konrad merged commit d0e46e59e8 into main 2021-09-09 22:25:08 +00:00
konrad deleted branch feature/checkbox_make-method-event-independent 2021-09-09 22:25:08 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
area/internal-code
changes requested
confirmed
dependencies
duplicate
This issue or pull request already exists
good first issue
help wanted
Need some help
hosting
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dpschen frederick konrad renovate
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/frontend#719
No description provided.
Delete Branch "dpschen/frontend:feature/checkbox_make-method-event-independent"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?