chore: define default filters and params at one location #721

dpschen · 2021-09-08T16:51:23Z

dpschen commented

2021-09-08 16:51:23 +00:00

No description provided.

konrad reviewed 2021-09-08 22:01:37 +00:00

src/components/list/partials/filters.vue Outdated

						
				@ -190,6 +190,35 @@ import ListService from '@/services/list'

				import NamespaceService from '@/services/namespace'

				import EditLabels from '@/components/tasks/partials/editLabels.vue'

				// FIXME: merge with DEFAULT_PARAMS in taskList.js

konrad commented

2021-09-08 22:01:37 +00:00

Ideally, I'd like to move this out of any .vue component and somewhere more centralized. Also becasue the whole logic of creating the filter is really fiddly and not a good api.

dpschen commented

2021-09-08 22:13:18 +00:00

Absolutely, this was just a small change that I did and felt too bad to discard it.
I know it's not the complete solution but a step in the right direction.
Also it's more in-line with how you would do stuff with the composition-api.

Absolutely, this was just a small change that I did and felt too bad to discard it. I know it's not the complete solution but a step in the right direction. Also it's more in-line with how you would do stuff with the composition-api.

dpschen force-pushed feature/define-default-filters-and-params from a77c62a5bb to fe94b267d3

2021-09-09 13:59:17 +00:00

Compare

dpschen changed title from ~~WIP: chore: define default filters and params at one location~~ to chore: define default filters and params at one location

2021-09-10 12:54:21 +00:00

konrad approved these changes 2021-09-10 13:02:16 +00:00

konrad merged commit b5df941e39 into main

2021-09-10 13:02:53 +00:00

konrad deleted branch feature/define-default-filters-and-params

2021-09-10 13:02:53 +00:00

konrad referenced this issue from a commit

2021-09-10 13:02:53 +00:00

chore: define default filters and params at one location (#721)

This repo is archived. You cannot comment on pull requests.

No reviewers