fix: vuex mutation error in edit list #813

dpschen · 2021-10-02T18:15:08Z

dpschen commented

2021-10-02 18:15:08 +00:00

No description provided.

dpschen added 1 commit 2021-10-02 18:15:09 +00:00

continuous-integration/drone/pr Build is passing Details

0ea7f89821

fix: vuex mutation error in edit list

dpschen reviewed 2021-10-02 18:17:07 +00:00

src/views/list/settings/edit.vue

						
				@ -107,4 +105,2 @@

							this.listService.get(list)

								.then(r => {

									this.$set(this, 'list', r)

									this.$store.commit(CURRENT_LIST, r)

dpschen commented

2021-10-02 18:17:07 +00:00

By settings the return value of listService to the store the list in the store was identical to this.list.
Because of that a change of e.g. list.title throws a vuex mutation error because it changes the title of that bucket in the store.

By settings the return value of listService to the store the list in the store was identical to `this.list`. Because of that a change of e.g. list.title throws a vuex mutation error because it changes the title of that bucket in the store.

konrad commented

2021-10-02 18:51:19 +00:00

Ohh really nice catch

dpschen reviewed 2021-10-02 18:18:51 +00:00

src/views/list/settings/edit.vue

						
				@ -117,6 +113,8 @@ export default {

						save() {

							this.$store.dispatch('lists/updateList', this.list)

								.then(() => {

									this.$store.commit(CURRENT_LIST, this.list)

dpschen commented

2021-10-02 18:18:51 +00:00

Since we don't want to change the store value until we are finished I commit the changed value only in the save function and only if the updateList was successfull.

dpschen commented

2021-10-02 18:20:03 +00:00

Since we don't want to change the store value until we are finished I commit the changed value only in the save function and only if the updateList was successfull.

Now that I think of it again, I'm not sure if that makes sense. But it seems to work! :P And in the vue3 branch it removes the mutation error (I didn't check this pull request, waiting for the pipeline here).

> Since we don't want to change the store value until we are finished I commit the changed value only in the save function and only if the updateList was successfull. Now that I think of it again, I'm not sure if that makes sense. But it seems to work! :P And in the vue3 branch it removes the mutation error (I didn't check this pull request, waiting for the pipeline here).