vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/vue3-async-await #832

Merged
dpschen merged 17 commits from dpschen/frontend:feature/vue3-async-await into vue3 2021-10-17 15:18:10 +00:00
Conversation 0 Commits 17 Files Changed 87 +1629 -2247
dpschen commented 2021-10-11 18:07:41 +00:00
Member
Copy Link

By using async / await we can hopefully save some bytes for the modern build.

Also it makes the code more readable by removing a lot of indention.
Mostly I was going through all the async functions.
I might have found reasons for race conditions.

By using async / await we can hopefully save some bytes for the modern build. Also it makes the code more readable by removing a lot of indention. Mostly I was going through all the async functions. I might have found reasons for race conditions.
dpschen added 26 commits 2021-10-11 18:07:42 +00:00
continuous-integration/drone/push Build is failing Details
36d4599276 fix: unassign user success messgage (#831) 
Co-authored-by: Dominik Pschenitschni <mail@celement.de>
Reviewed-on: #831
Reviewed-by: konrad <k@knt.li>
Co-authored-by: dpschen <dpschen@noreply.kolaente.de>
Co-committed-by: dpschen <dpschen@noreply.kolaente.de>
continuous-integration/drone/push Build is passing Details
3c5c3cad10 chore: remove unneeded babel packages and add peerDependencies (#828) 
Co-authored-by: Dominik Pschenitschni <mail@celement.de>
Reviewed-on: #828
Reviewed-by: konrad <k@knt.li>
Co-authored-by: dpschen <dpschen@noreply.kolaente.de>
Co-committed-by: dpschen <dpschen@noreply.kolaente.de>
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
17d791027c
feat: add legacy build
35c861b711
feat: create randomId helper and use everywhere 
Co-authored-by: konrad <konrad@kola-entertainments.de>
continuous-integration/drone/pr Build is passing Details
fd77aaa123
fix: add timeout to wait for move to finish
continuous-integration/drone/pr Build is passing Details
18d7ca0820
feat: also use createRandomID helper in editor
continuous-integration/drone/pr Build is passing Details
5cfb99bfc2
Merge branch 'main' into feature/vue3-implementation-improvements 
# Conflicts:
#	package.json
#	vite.config.js
#	yarn.lock
d1b61a1489
feat: some vue3 package improvements 
- add codemirror as direct dependency
- remove @vue/runtime-dom (was needed for volar with vue2)
- remove setting for using volar with vue2
continuous-integration/drone/pr Build is failing Details
18c31482df
fix: remove side effect from computed 
was firing a commit
continuous-integration/drone/pr Build is failing Details
cc8b03778c
fix: use correct method for fakers uuid
dpschen changed title from feature/vue3-async-await to wip: feature/vue3-async-await 2021-10-11 18:07:58 +00:00
dpschen added a new dependency 2021-10-11 18:09:04 +00:00
#814 feature/vue3-implementation-improvements
dpschen added the
changes requested
 label 2021-10-11 18:09:22 +00:00
dpschen force-pushed feature/vue3-async-await from dc48d17576 to 6cfb1e107d 2021-10-11 19:42:16 +00:00 Compare
dpschen removed a dependency 2021-10-12 14:12:51 +00:00
#814 feature/vue3-implementation-improvements
dpschen added a new dependency 2021-10-12 14:13:00 +00:00
#833 feature/vue3-global-error-management
dpschen force-pushed feature/vue3-async-await from 6cfb1e107d to b3774c3cfa 2021-10-15 18:11:39 +00:00 Compare
dpschen force-pushed feature/vue3-async-await from b3774c3cfa to 2aa4e09344 2021-10-15 18:18:27 +00:00 Compare
dpschen added the
kind/feature
 label 2021-10-15 18:32:22 +00:00
dpschen force-pushed feature/vue3-async-await from 2aa4e09344 to c1139ae57d 2021-10-15 18:49:14 +00:00 Compare
dpschen force-pushed feature/vue3-async-await from c1139ae57d to 99d52eed2f 2021-10-15 19:24:16 +00:00 Compare
dpschen force-pushed feature/vue3-async-await from 99d52eed2f to fadc9f2e80 2021-10-16 11:03:33 +00:00 Compare
dpschen force-pushed feature/vue3-async-await from fadc9f2e80 to bf41f09ac1 2021-10-16 13:23:45 +00:00 Compare
dpschen force-pushed feature/vue3-async-await from 57d00878fa to 7d07256ed1 2021-10-16 15:56:48 +00:00 Compare
dpschen force-pushed feature/vue3-async-await from 7d07256ed1 to 676ab1cb0a 2021-10-16 16:26:11 +00:00 Compare
dpschen force-pushed feature/vue3-async-await from 9da4bc0853 to 7f5f44d7f0 2021-10-16 17:00:07 +00:00 Compare
dpschen added 1 commit 2021-10-16 18:44:55 +00:00
continuous-integration/drone/pr Build is passing Details
a60ad77bdc
fix: use async action to change current list
dpschen removed a dependency 2021-10-16 18:49:42 +00:00
#833 feature/vue3-global-error-management
konrad approved these changes 2021-10-16 19:21:48 +00:00
src/components/migrator/migration.vue Outdated
@ -153,2 +144,2 @@
this.$message.error(e)
})
async getAuthUrl() {
const { url } = this.migrationService.getAuthUrl()
konrad commented 2021-10-16 19:05:45 +00:00
Owner

Isn't there an await missing here?

Isn't there an `await` missing here?
dpschen commented 2021-10-17 10:50:37 +00:00
Author
Member

Yes! Good catch!

Yes! Good catch!
dpschen marked this conversation as resolved
src/views/list/settings/background.vue Outdated
@ -71,6 +71,10 @@ import ListService from '@/services/list'
import {CURRENT_LIST} from '@/store/mutation-types'
import CreateEdit from '@/components/misc/create-edit.vue'
function timeout(ms) {
konrad commented 2021-10-16 19:19:41 +00:00
Owner

I feel like this function should go into some helper module.

I feel like this function should go into some helper module.
dpschen commented 2021-10-17 12:53:28 +00:00
Author
Member

Used lodash.debounce in c1078255fc

Used `lodash.debounce` in https://kolaente.dev/vikunja/frontend/commit/c1078255fc836f4609bda779cfac3f713b7b720b
dpschen marked this conversation as resolved
dpschen added 1 commit 2021-10-17 11:49:04 +00:00
continuous-integration/drone/pr Build is failing Details
56365591cf
fix: await getAuthUrl
dpschen added 1 commit 2021-10-17 12:47:50 +00:00
konrad added 1 commit 2021-10-17 13:19:26 +00:00
continuous-integration/drone/pr Build is failing Details
0cc7166767
fix: don't search for first letter images
dpschen added a new dependency 2021-10-17 13:29:06 +00:00
#862 feature/vue3-make-workbox-debug-configurable
dpschen added 1 commit 2021-10-17 14:07:23 +00:00
continuous-integration/drone/pr Build is failing Details
2ac3d29c13
Merge branch 'vue3' into feature/vue3-async-await 
# Conflicts:
#	src/i18n/index.js
#	src/store/modules/labels.js
#	src/store/modules/tasks.js
#	src/views/list/views/Kanban.vue
#	src/views/tasks/ShowTasks.vue
#	src/views/tasks/TaskDetailView.vue
konrad added 1 commit 2021-10-17 14:22:51 +00:00
continuous-integration/drone/pr Build is failing Details
9fc158831b
Merge branch 'vue3' into feature/vue3-async-await
konrad added 1 commit 2021-10-17 14:27:17 +00:00
continuous-integration/drone/pr Build is failing Details
2de94bc902
fix: lint
dpschen added 1 commit 2021-10-17 14:30:42 +00:00
continuous-integration/drone/pr Build is failing Details
ae971b23bc
fix: sort order by dueDate, then by id
konrad added 1 commit 2021-10-17 15:06:41 +00:00
continuous-integration/drone/pr Build is failing Details
1d46b85170
fix: loading labels after login
dpschen changed title from wip: feature/vue3-async-await to feature/vue3-async-await 2021-10-17 15:13:14 +00:00
dpschen merged commit 4e893a3196 into vue3 2021-10-17 15:18:10 +00:00
dpschen deleted branch feature/vue3-async-await 2021-10-17 15:18:10 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#862 feature/vue3-make-workbox-debug-configurable
vikunja/frontend
Reference: vikunja/frontend#832
No description provided.
Delete Branch "dpschen/frontend:feature/vue3-async-await"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?