vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: pagination in vue 3 #859

Merged
dpschen merged 5 commits from fix/pagination-vue-3 into vue3 2021-10-16 15:39:51 +00:00
Conversation 0 Commits 5 Files Changed 1 +43 -46
konrad commented 2021-10-16 12:39:54 +00:00
Owner
Copy Link

This fixes using Vikunja with pagination.

Explanation about what was happening is here: https://github.com/vuejs/vue-next/issues/4812

This fixes using Vikunja with pagination. Explanation about what was happening is here: https://github.com/vuejs/vue-next/issues/4812
konrad added 1 commit 2021-10-16 12:39:55 +00:00
continuous-integration/drone/pr Build is passing Details
4ec79f7d7e
fix: pagination in vue 3
dpschen reviewed 2021-10-16 12:42:01 +00:00
src/components/misc/pagination.vue Outdated
@ -101,3 +101,3 @@
computed: {
pages() {
return createPagination(this.totalPages, this.currentPage)
const pages = createPagination(this.totalPages, this.currentPage)
dpschen commented 2021-10-16 12:42:01 +00:00
Member

I think this can be changed back

I think this can be changed back
konrad commented 2021-10-16 12:46:04 +00:00
Author
Owner

Whoops, didn't mean to push that. Fixed.

Whoops, didn't mean to push that. Fixed.
konrad marked this conversation as resolved
konrad added 1 commit 2021-10-16 12:46:05 +00:00
continuous-integration/drone/pr Build was killed Details
2f73ed06b7
chore: cleanup computed property
konrad added 2 commits 2021-10-16 12:47:58 +00:00
continuous-integration/drone/pr Build was killed Details
9d4003cd12
chore: format
konrad added 1 commit 2021-10-16 12:48:13 +00:00
continuous-integration/drone/pr Build is passing Details
e4a22391a0
fix: rename key
dpschen merged commit 373a766f5c into vue3 2021-10-16 15:39:51 +00:00
dpschen deleted branch fix/pagination-vue-3 2021-10-16 15:39:51 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#859
No description provided.
Delete Branch "fix/pagination-vue-3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?