feat: allow openid users to export their data without a password #918

Merged
konrad merged 2 commits from featuer/export-for-openid-users into main 2021-10-31 13:16:29 +00:00
Owner

This PR implements a check to only require local users to provide their password when requesting an export of their Vikunja data. Currently, it is not possible for these kinds of users to request their data because the export was built with local users only in mind.

Requires 516c812043 and 9eca971c93 from the api to work.

This PR implements a check to only require local users to provide their password when requesting an export of their Vikunja data. Currently, it is not possible for these kinds of users to request their data because the export was built with local users only in mind. Requires https://kolaente.dev/vikunja/api/commit/516c812043e77be7f834ae1326d13d39e156ef77 and https://kolaente.dev/vikunja/api/commit/9eca971c938699d481915fb6e14c765aea1fa3b5 from the api to work.
konrad added 1 commit 2021-10-31 11:43:56 +00:00
dpschen reviewed 2021-10-31 13:07:45 +00:00
@ -17,3 +4,1 @@
@keyup="() => errPasswordRequired = password === ''"
ref="passwordInput"
/>
<template v-if="passwordRequired">

I think we should either rename this var or note somewhere why no password is required.

I think we should either rename this var or note somewhere _why_ no password is required.
Author
Owner

Agreed, changed.

Agreed, changed.
dpschen marked this conversation as resolved
konrad added 1 commit 2021-10-31 13:09:57 +00:00
dpschen approved these changes 2021-10-31 13:11:53 +00:00
dpschen left a comment
Member

Looks good

Looks good
konrad merged commit 5b406b0172 into main 2021-10-31 13:16:29 +00:00
konrad deleted branch featuer/export-for-openid-users 2021-10-31 13:16:29 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.