feat: add releases to sentry #919

konrad · 2021-10-31T12:21:53Z

konrad commented

2021-10-31 12:21:53 +00:00

No description provided.

dpschen commented

2021-10-31 12:42:09 +00:00

That makes sense =) Does by settings this sentry also use the commit sha?

konrad commented

2021-10-31 12:47:22 +00:00

I think it should, at least for unstable releases. The version number for those is something like 0.18.1+378-e1a7fb4999 which includes the commit hash.

I think it should, at least for unstable releases. The version number for those is something like `0.18.1+378-e1a7fb4999` which includes the commit hash.

konrad force-pushed feature/sentry-releases from da2f93841b to 9dc99186e2

2021-10-31 12:48:51 +00:00

Compare

dpschen commented

2021-10-31 12:56:39 +00:00

Ahh okay, but not for local commits and not merged branches.
Maybe we can do that too: https://docs.sentry.io/product/releases/suspect-commits/

Ahh okay, but not for local commits and not merged branches. Maybe we can do that too: https://docs.sentry.io/product/releases/suspect-commits/

konrad commented

2021-10-31 13:06:34 +00:00

Ahh okay, but not for local commits and not merged branches.

But local commits probably won't use sentry since they are not deployed?

Maybe we can do that too: https://docs.sentry.io/product/releases/suspect-commits/

Probably, yeah. That would only use released commits (even though unstable) though, so no local commits or not merged branches either.

> Ahh okay, but not for local commits and not merged branches. But local commits probably won't use sentry since they are not deployed? > Maybe we can do that too: https://docs.sentry.io/product/releases/suspect-commits/ Probably, yeah. That would only use released commits (even though unstable) though, so no local commits or not merged branches either.

dpschen commented

2021-10-31 13:09:00 +00:00

Ahh okay, but not for local commits and not merged branches.

But local commits probably won't use sentry since they are not deployed?

Why that?

> > Ahh okay, but not for local commits and not merged branches. > > But local commits probably won't use sentry since they are not deployed? Why that?

konrad commented

2021-10-31 13:14:03 +00:00

Sure, you could enable sentry for local commits but that would only take effect with a production build and deployed somewhere other than localhost. At that point you could just use the unstable build... And you probably want to see the errors when developing locally instead of digging into sentry for that.
And it would also require me to allow anyone to add commits to sentry which I'd like to avoid.

Sure, you could enable sentry for local commits but that would only take effect with a production build and deployed somewhere other than `localhost`. At that point you could just use the unstable build... And you probably want to see the errors when developing locally instead of digging into sentry for that. And it would also require me to allow anyone to add commits to sentry which I'd like to avoid.

dpschen commented

2021-10-31 13:23:22 +00:00

Sure, you could enable sentry for local commits but that would only take effect with a production build and deployed somewhere other than localhost. At that point you could just use the unstable build... And you probably want to see the errors when developing locally instead of digging into sentry for that.
And it would also require me to allow anyone to add commits to sentry which I'd like to avoid.

I didn't check the docs but I think it's possible to do this somehow with a local token or something.

By doing so we found some errors in a larger project, I onced worked on, that were rare, but did happen from time to time and were maybe missed because the console wasn't open when they happend.

Right now we do have those notifications for all the errors. So that makes them more verbose than usually. Still you could miss a notification by simply not paying attention. In Sentry itself you can also filter by host so the overview doesn't go away.

But all of that is for sure optional, so no need! =)

> Sure, you could enable sentry for local commits but that would only take effect with a production build and deployed somewhere other than `localhost`. At that point you could just use the unstable build... And you probably want to see the errors when developing locally instead of digging into sentry for that. > And it would also require me to allow anyone to add commits to sentry which I'd like to avoid. I didn't check the docs but I think it's possible to do this somehow with a local token or something. By doing so we found some errors in a larger project, I onced worked on, that were rare, but did happen from time to time and were maybe missed because the console wasn't open when they happend. Right now we do have those notifications for all the errors. So that makes them more verbose than usually. Still you could miss a notification by simply not paying attention. In Sentry itself you can also filter by host so the overview doesn't go away. But all of that is for sure optional, so no need! =)

👍 1

dpschen approved these changes 2021-10-31 13:25:41 +00:00

konrad merged commit 1873c74776 into main

2021-10-31 13:37:57 +00:00

konrad deleted branch feature/sentry-releases

2021-10-31 13:37:58 +00:00

konrad referenced this issue from a commit

2021-10-31 13:37:58 +00:00

feat: add releases to sentry (#919)

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#919