feature/use-setup-api-for-user-and-about-pages #929
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#929
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/use-setup-api-for-user-and-about-pages"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
991141b7de
to3bf7867be5
3bf7867be5
tob5d6595509
b5d6595509
to4877689216
4877689216
toc65eccc3cb
feature/use-setup-api-for-user-and-about-pagesto WIP: feature/use-setup-api-for-user-and-about-pagesc65eccc3cb
to7b0657eacd
7b0657eacd
tof680995481
f680995481
to507efbf17b
@ -117,3 +104,1 @@
}
},
beforeMount() {
beforeRouteEnter() {
Damn. I need some stuff from the auth branch. Will continue to work there.
This is a suboptimal solution either way…
Solved with temporary solution.
Using
onBeforeMount
so exactly as good as solution before.507efbf17b
to505fa1045d
505fa1045d
to7d322f925a
7d322f925a
to95186a94c9
Hi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://929-featureuse-setup-api-for-user-and-about-pages--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
WIP: feature/use-setup-api-for-user-and-about-pagesto feature/use-setup-api-for-user-and-about-pages@ -27,2 +27,2 @@
cy.get('#password1').type(fixture.password)
cy.get('#password2').type(fixture.password)
cy.get('#password').type(fixture.password)
cy.get('#passwordValidation').type(fixture.password)
That's a lot better!
@ -6,2 +1,2 @@
document.title = `${title} | Vikunja`
export function setTitle(title) {
document.title = typeof title === 'undefined' || title === ''
Shouldn't this be
(with braces)?
Shall I revert then? My changes don't make it much better then
I think that would work.
@ -82,0 +61,4 @@
const { t } = useI18n()
useTitle(() => t('user.auth.resetPassword'))
// Not sure if this instance needs a shalloRef at all
There's the loading state on the submit button. Doesn't that require a shallowRef?
Yeah what I meant is that I was not sure if a ref or reactive makes more sense.
In cases of "libs" I'm still not always sure what makes most sense.
Now that I think of it: It might be better a reactive. (Ref would also be fine but reactive seems nicer to use in the case).
95186a94c9
to4601b8a3a2
4601b8a3a2
toaa43ead3a8
aa43ead3a8
to237e510774