chore: don't spread arguments #933

dpschen · 2021-11-01T18:58:23Z

dpschen commented

2021-11-01 18:58:23 +00:00

No description provided.

dpschen added 1 commit 2021-11-01 18:58:24 +00:00

continuous-integration/drone/pr Build is passing Details

19322cbd42

fix: don't spread arguments

dpschen reviewed 2021-11-01 18:58:45 +00:00

src/store/modules/auth.js

						
				@ -120,12 +120,9 @@ export default {

						// Not sure if this is the right place to put the logic in, maybe a seperate js component would be better suited.

						async register(ctx, credentials) {

							const HTTP = HTTPFactory()

							ctx.commit(LOADING, true, {root: true})

dpschen commented

2021-11-01 18:58:45 +00:00

Was not sure here, but seems to have been missing.

konrad commented

2021-11-02 18:12:34 +00:00

Good catch!

konrad commented

2021-11-02 18:14:33 +00:00

Though I just noticed that's already being set in the register component (which is bad). Could you remove it there? Not nessecarily here in this PR, another one is fine.

Though I just noticed that's already being set [in the register component](https://kolaente.dev/vikunja/frontend/src/branch/main/src/views/user/Register.vue#L134) (which is bad). Could you remove it there? Not nessecarily here in this PR, another one is fine.

konrad commented

2021-11-02 18:17:10 +00:00

Created a follow-up: #939

Created a follow-up: https://kolaente.dev/vikunja/frontend/pulls/939