vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: allow selecting multiple labels at once #945

Merged
konrad merged 3 commits from feature/multiple-labels into main 2021-11-09 19:07:07 +00:00
Conversation 1 Commits 3 Files Changed 2 +20 -16
konrad commented 2021-11-03 21:29:14 +00:00
Owner
Copy Link

Fixes #663

Fixes https://kolaente.dev/vikunja/frontend/issues/663
konrad force-pushed feature/multiple-labels from 112b2a711b to ee68227065 2021-11-03 21:30:12 +00:00 Compare
konrad requested review from dpschen 2021-11-03 21:34:31 +00:00
dpschen reviewed 2021-11-04 10:18:00 +00:00
src/components/input/multiselect.vue Outdated
@ -182,1 +184,4 @@
},
closeAfterSelect: {
type: Boolean,
default() {
dpschen commented 2021-11-04 10:18:00 +00:00
Member

since boolean is a primitive there is no need for a factory function here.

since boolean is a primitive there is no need for a factory function here.
konrad commented 2021-11-09 18:47:55 +00:00
Author
Owner

Done.

Done.
konrad marked this conversation as resolved
dpschen reviewed 2021-11-04 10:19:14 +00:00
src/components/input/multiselect.vue Outdated
@ -10,1 +10,3 @@
<div class="input-wrapper input" :class="{'has-multiple': multiple && Array.isArray(internalValue) && internalValue.length > 0}">
<div
class="input-wrapper input"
:class="{'has-multiple': multiple && Array.isArray(internalValue) && internalValue.length > 0}">
dpschen commented 2021-11-04 10:19:14 +00:00
Member

Move to computed

Move to computed
konrad commented 2021-11-09 18:49:39 +00:00
Author
Owner

Done.

Done.
konrad marked this conversation as resolved
dpschen approved these changes 2021-11-04 10:21:18 +00:00
dpschen left a comment
Member

Mini changes. Rest ist fine =)

Mini changes. Rest ist fine =)
konrad was assigned by dpschen 2021-11-04 10:21:38 +00:00
konrad added 1 commit 2021-11-09 18:47:45 +00:00
konrad added 1 commit 2021-11-09 18:49:34 +00:00
continuous-integration/drone/pr Build is passing Details
70f78758a2
chore: move has multiple calculation to computed
konrad commented 2021-11-09 19:06:56 +00:00
Author
Owner
Copy Link

Merging since it's approved and the little nits are fixed.

Merging since it's approved and the little nits are fixed.
🎉 1
konrad merged commit 9b7882de7a into main 2021-11-09 19:07:07 +00:00
konrad deleted branch feature/multiple-labels 2021-11-09 19:07:07 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
dpschen
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#945
No description provided.
Delete Branch "feature/multiple-labels"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?