vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: wrap edit-task with card #948

Merged
konrad merged 1 commits from dpschen/frontend:feature/add-card-inside-EditTask into main 2021-11-13 14:13:57 +00:00
Conversation 3 Commits 1 Files Changed 9 +51 -41
dpschen commented 2021-11-04 13:47:57 +00:00
Member
Copy Link
  • style is currently broken. I wanted to compare to try.vikunja.com but login failed
  • changed default close icon to times. seemed appropriate since this is the actual action happening. if we would collapse the card and there would be a way to uncollapse the 'angle-right' would be fine.
  • removed 'has-background-white' on Card components. Reason: Card contains that style already.
- style is currently broken. I wanted to compare to try.vikunja.com but login failed - changed default close icon to times. seemed appropriate since this is the actual action happening. if we would collapse the card and there would be a way to uncollapse the 'angle-right' would be fine. - removed 'has-background-white' on Card components. Reason: Card contains that style already.
dpschen changed title from feat: wrap edit-task with card to WIP: feat: wrap edit-task with card 2021-11-04 13:48:04 +00:00
konrad commented 2021-11-09 22:54:41 +00:00
Owner
Copy Link

Looks good so far. What styles are broken?

Looks good so far. What styles are broken?
dpschen changed title from WIP: feat: wrap edit-task with card to feat: wrap edit-task with card 2021-11-11 01:22:43 +00:00
dpschen commented 2021-11-11 01:30:28 +00:00
Author
Member
Copy Link

Looks good so far. What styles are broken?

I thought in the gantt view. But it seems that the positioning of the open task is also broken in try.vikunja.io. That's a different issue. Feel free to review =)

> Looks good so far. What styles are broken? I thought in the gantt view. But it seems that the positioning of the open task is also broken in try.vikunja.io. That's a different issue. Feel free to review =)
dpschen requested review from konrad 2021-11-11 01:30:37 +00:00
dpschen force-pushed feature/add-card-inside-EditTask from 074a5ed9f4 to d521412a94 2021-11-11 01:41:10 +00:00 Compare
konrad approved these changes 2021-11-13 14:13:39 +00:00
konrad merged commit 8e6e52bf02 into main 2021-11-13 14:13:57 +00:00
konrad deleted branch feature/add-card-inside-EditTask 2021-11-13 14:13:57 +00:00
konrad commented 2021-11-13 14:14:26 +00:00
Owner
Copy Link

The whole gantt view is a topic for another day...

The whole gantt view is a topic for another day...
👍 1
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#948
No description provided.
Delete Branch "dpschen/frontend:feature/add-card-inside-EditTask"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?