vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: use script setup for filter views #951

Merged
konrad merged 1 commits from dpschen/frontend:feature/use-script-setup-for-filter-views into main 2021-11-14 15:56:52 +00:00
Conversation 10 Commits 1 Files Changed 7 +210 -209
dpschen commented 2021-11-04 15:18:19 +00:00
Member
Copy Link
No description provided.
dpschen changed title from WIP: feat: use script setup for filter views to feat: use script setup for filter views 2021-11-04 16:12:31 +00:00
konrad commented 2021-11-09 22:45:22 +00:00
Owner
Copy Link

Editing a filter seems to fail:

image

I think because the filterService is not exposed in the frontend? And because of that it can't set the loading state based on filterService.loading.

Editing a filter seems to fail: ![image](/attachments/e6a1d093-ae66-4a70-971e-e688b8912da8) I think because the `filterService` is not exposed in the frontend? And because of that it can't set the loading state based on `filterService.loading`.
image.png
82 KiB
👍 1
konrad reviewed 2021-11-09 22:47:47 +00:00
src/views/filters/FilterNew.vue Outdated
konrad commented 2021-11-09 22:47:16 +00:00
Owner

Did you test that? I'm relatively sure this was due to some race condition breaking things - probably not an ideal way to work around it the way I did though, if it does not happen anymore it should be fine.

Did you test that? I'm relatively sure this was due to some race condition breaking things - probably not an ideal way to work around it the way I did though, if it does not happen anymore it should be fine.
dpschen commented 2021-11-11 02:07:28 +00:00
Author
Member

My idea was that with the changed savedFilter.id the element gets a new key and thus gets remounted => has the same sideeffect.
But no, didn't test :/

My idea was that with the changed `savedFilter.id` the element gets a new key and thus gets remounted => has the same sideeffect. But no, didn't test :/
dpschen was assigned by konrad 2021-11-09 22:48:12 +00:00
dpschen force-pushed feature/use-script-setup-for-filter-views from 51f9e46432 to 18d1a61e13 2021-11-11 02:06:26 +00:00 Compare
dpschen commented 2021-11-11 21:55:32 +00:00
Author
Member
Copy Link

Editing a filter seems to fail:

image

I think because the filterService is not exposed in the frontend? And because of that it can't set the loading state based on filterService.loading.

Fixed

> Editing a filter seems to fail: > > ![image](/attachments/e6a1d093-ae66-4a70-971e-e688b8912da8) > > I think because the `filterService` is not exposed in the frontend? And because of that it can't set the loading state based on `filterService.loading`. Fixed
konrad commented 2021-11-13 14:08:06 +00:00
Owner
Copy Link

Now there's this:

image

Not sure if related to the pr?

Now there's this: ![image](/attachments/c5afc66a-d4b8-4c20-8f0e-84a1968934bb) Not sure if related to the pr?
image.png
26 KiB
dpschen commented 2021-11-13 14:09:19 +00:00
Author
Member
Copy Link

Now there's this:

image

Not sure if related to the pr?

When do you get that?

> Now there's this: > > ![image](/attachments/c5afc66a-d4b8-4c20-8f0e-84a1968934bb) > > Not sure if related to the pr? When do you get that?
konrad commented 2021-11-13 14:09:50 +00:00
Owner
Copy Link

When editing a filter.

When editing a filter.
👍 1
dpschen commented 2021-11-13 18:37:27 +00:00
Author
Member
Copy Link

Now there's this:

image

Not sure if related to the pr?

Fixed in 13da68f517~

EDIT: force pushed. see comment below

> Now there's this: > > ![image](/attachments/c5afc66a-d4b8-4c20-8f0e-84a1968934bb) > > Not sure if related to the pr? ~~Fixed in https://kolaente.dev/vikunja/frontend/commit/13da68f517a46cc6cada649012361344e43322ec~~~ EDIT: force pushed. see comment below
dpschen force-pushed feature/use-script-setup-for-filter-views from 13da68f517 to 1d2f1212cc 2021-11-13 18:38:22 +00:00 Compare
dpschen reviewed 2021-11-13 18:39:14 +00:00
src/components/list/partials/filters.vue Outdated
@ -264,1 +266,3 @@
this.params = value
// FIXME: filters should only be converted to snake case in
// the last moment
this.params = objectToSnakeCase(value)
dpschen commented 2021-11-13 18:39:14 +00:00
Author
Member

@konrad: Fixed with this

@konrad: Fixed with this
👍 1
frederick commented 2021-11-13 18:48:05 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://951-featureuse-script-setup-for-filter-views--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://951-featureuse-script-setup-for-filter-views--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad commented 2021-11-13 20:01:10 +00:00
Owner
Copy Link

It looks like the filter does not get popuplated when editing:

image

The filter title should be present in the input.

It looks like the filter does not get popuplated when editing: ![image](/attachments/3cc75bd0-a9f2-4b73-931f-6f2394552bbc) The filter title should be present in the input.
image.png
20 KiB
👍 1
dpschen force-pushed feature/use-script-setup-for-filter-views from 1d2f1212cc to 04e0ea03fb 2021-11-14 13:07:47 +00:00 Compare
dpschen commented 2021-11-14 13:08:22 +00:00
Author
Member
Copy Link

It looks like the filter does not get popuplated when editing:

image

The filter title should be present in the input.

Good catch. Was missing a immediate: true in the watcher =)

> It looks like the filter does not get popuplated when editing: > > ![image](/attachments/3cc75bd0-a9f2-4b73-931f-6f2394552bbc) > > The filter title should be present in the input. Good catch. Was missing a `immediate: true` in the watcher =)
dpschen requested review from konrad 2021-11-14 13:08:30 +00:00
dpschen commented 2021-11-14 13:08:53 +00:00
Author
Member
Copy Link

@konrad: can you check again? =)

@konrad: can you check again? =)
konrad approved these changes 2021-11-14 15:56:46 +00:00
konrad left a comment
Owner

Looks like everything is working now. Thanks!

Looks like everything is working now. Thanks!
konrad merged commit e63fd587c8 into main 2021-11-14 15:56:52 +00:00
konrad deleted branch feature/use-script-setup-for-filter-views 2021-11-14 15:56:53 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dpschen
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#951
No description provided.
Delete Branch "dpschen/frontend:feature/use-script-setup-for-filter-views"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?