vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: add vite-svg-loader and add Logo component #971

Merged
konrad merged 2 commits from dpschen/frontend:feature/add-vite-svg-loader into main 2021-11-13 14:16:15 +00:00
Conversation 3 Commits 2 Files Changed 22 +335 -238
dpschen commented 2021-11-10 19:41:30 +00:00
Member
Copy Link

This should fulfill the requirement for adrinux/frontend#1

This should fulfill the requirement for https://kolaente.dev/adrinux/frontend/issues/1
konrad reviewed 2021-11-10 19:44:04 +00:00
src/components/home/Logo.vue Outdated
@ -0,0 +3,4 @@
import LogoFull from '@/assets/logo-full.svg?component'
import LogoFullPride from '@/assets/logo-full-pride.svg?component'
const Logo = computed(() => new Date().getMonth() === 5 ? LogoFullPride : LogoFull)
konrad commented 2021-11-10 19:44:04 +00:00
Owner

Oh wow I did not know you could literally define a component as computed... vue continues to amaze me. Really cool!

Oh wow I did not know you could literally define a component as computed... vue continues to amaze me. Really cool!
dpschen commented 2021-11-10 21:52:52 +00:00
Author
Member

=)

=)
dpschen commented 2021-11-10 21:58:48 +00:00
Author
Member

I knew that it works with computed but in this case I was also not sure if it would work.

Since Logo is here a ref and not a component, I was unsure if I needed to do something like <Logo.value ... which doesn't really make sense because .value is usually not needed, but still … was unsure :D

I knew that it works with computed but in this case I was also not sure if it would work. Since Logo is here a ref and not a component, I was unsure if I needed to do something like `<Logo.value ...` which doesn't really make sense because `.value` is usually not needed, but still … was unsure :D
👀 1
konrad marked this conversation as resolved
konrad reviewed 2021-11-10 19:46:48 +00:00
src/components/home/contentNoAuth.vue Outdated
@ -69,3 +66,3 @@
<style lang="scss" scoped>
.no-auth-wrapper {
background: url('@/assets/llama.svg') no-repeat bottom left fixed $light-background;
background: url('@/assets/llama.svg?url') no-repeat bottom left fixed $light-background;
konrad commented 2021-11-10 19:45:38 +00:00
Owner

Why the ?url?

Why the `?url`?
konrad commented 2021-11-10 21:08:52 +00:00
Owner

Ahh looked up how the module works, makes sense now.

Ahh looked up how the module works, makes sense now.
👍 1
konrad marked this conversation as resolved
konrad requested changes 2021-11-10 21:10:18 +00:00
konrad left a comment
Owner

Looks like the logo size got missing:

image

This is what it should look like:

image

Looks like the logo size got missing: ![image](/attachments/75688c72-6b0d-4996-ae75-8093ecf3c060) This is what it should look like: ![image](/attachments/f5b11148-df01-4e08-8195-cd2d72399f22)
image.png
4.1 KiB
image.png
5.6 KiB
dpschen force-pushed feature/add-vite-svg-loader from a653c9d590 to 88b4733c90 2021-11-11 00:58:26 +00:00 Compare
frederick commented 2021-11-11 01:00:33 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://971-featureadd-vite-svg-loader--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://971-featureadd-vite-svg-loader--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
🎉 1
dpschen requested review from konrad 2021-11-11 01:08:13 +00:00
dpschen force-pushed feature/add-vite-svg-loader from 88b4733c90 to 81e36dc76d 2021-11-11 01:56:22 +00:00 Compare
dpschen commented 2021-11-12 17:38:39 +00:00
Author
Member
Copy Link

@konrad should be fixed

@konrad should be fixed
konrad approved these changes 2021-11-13 13:47:11 +00:00
konrad force-pushed feature/add-vite-svg-loader from 81e36dc76d to 44ecdf6922 2021-11-13 13:48:35 +00:00 Compare
konrad commented 2021-11-13 13:49:14 +00:00
Owner
Copy Link

Rebased, will merge once the ci run passes.

Rebased, will merge once the [ci run](https://drone.kolaente.de/vikunja/frontend/4046) passes.
konrad merged commit 30cc89fe25 into main 2021-11-13 14:16:15 +00:00
konrad deleted branch feature/add-vite-svg-loader 2021-11-13 14:16:15 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#971
No description provided.
Delete Branch "dpschen/frontend:feature/add-vite-svg-loader"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?