fix: show current host if configured api url is /api/v1 instead of "" #994

konrad · 2021-11-13T20:35:41Z

konrad commented

2021-11-13 20:35:41 +00:00

No description provided.

konrad added 1 commit 2021-11-13 20:35:41 +00:00

continuous-integration/drone/pr Build is passing Details

a22fdda46d

fix: show current host if configured api url is /api/v1 instead of ""

frederick commented

2021-11-13 20:39:56 +00:00

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://994-fixshow-current-host--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://994-fixshow-current-host--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dpschen requested changes 2021-11-14 12:57:43 +00:00

src/components/misc/api-config.vue Outdated

						
				@ -69,2 +69,3 @@

						apiDomain() {

							return parseURL(this.apiUrl).host

							const configuredHost = parseURL(this.apiUrl).host

							if (configuredHost) {

dpschen commented

2021-11-14 12:55:35 +00:00

Picky: ~~return once and use ternary operator~~~

Maybe even better:

return parseURL(this.apiUrl).host || parseURL(window.location.href).host

Picky: ~~return once and use ternary operator~~~ Maybe even better: ```js return parseURL(this.apiUrl).host || parseURL(window.location.href).host ```

konrad commented

2021-11-14 15:54:06 +00:00

That looks nice. Changed!

🚀 1

konrad marked this conversation as resolved

konrad added 1 commit 2021-11-14 15:53:53 +00:00