vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

WIP: fix: don't try to load a task view with the id of the list #1252

Closed
konrad wants to merge 1 commits from fix/load-task-as-list into main
pull from: fix/load-task-as-list
merge into: vikunja:main
Conversation 3 Commits 1 Files Changed 1 +7
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/views/tasks/TaskDetailView.vue
View File

@ -524,6 +524,13 @@ export default {
},
computed: {
taskId() {
// This ensures we're actually dealing with a task route and not trying to load a task with the id of
// its list. When closing the modal, this watcher gets triggered because the route param of the list
// route is also called "id".
if (!this.$route.name.startsWith('task')) {
return undefined
}
const {id} = this.$route.params
konrad commented 2021-12-26 18:06:17 +00:00
Review
Copy Link

Maybe a better fix would be to rename the param in the router config to something like taskId?

Maybe a better fix would be to rename the param in the router config to something like `taskId`?
dpschen commented 2022-01-04 20:19:55 +00:00
Review
Copy Link

Yes that makes sense. I do actually already the opposite in the modal branch:
I renamed the list id param in listId. E.g. 43c935ca41/src/router/index.ts (L263)

Yes that makes sense. I do actually already the opposite in the modal branch: I renamed the list id param in `listId`. E.g. https://kolaente.dev/dpschen/frontend/src/commit/43c935ca4141de6f85bb22c959b730a4e7d04854/src/router/index.ts#L263
konrad commented 2022-01-05 14:28:44 +00:00
Review
Copy Link

So this PR will probably get obsolete once we merge the modal one?

So this PR will probably get obsolete once we merge the modal one?
dpschen commented 2022-01-05 14:51:12 +00:00
Review
Copy Link

I think so, yes

I think so, yes
👍 1
konrad commented 2022-01-05 16:48:31 +00:00
Review
Copy Link

Okay, I'll set this to wip until the other one is merged so we don't accedentially merge this.

Okay, I'll set this to wip until the other one is merged so we don't accedentially merge this.
👍 1
return id === undefined ? id : Number(id)
},