vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: remove some of the typescript warnings #1304

Merged
dpschen merged 1 commits from dpschen/frontend:feature/fix-some-typescript-warnings into main 2022-01-05 15:45:55 +00:00
Conversation 1 Commits 1 Files Changed 12 +76 -62
dpschen commented 2022-01-05 10:06:55 +00:00
Member
Copy Link

related: #1295

This will reduce the currently thrown warnings down to (currently) 20

related: https://kolaente.dev/vikunja/frontend/pulls/1295 This will reduce the currently thrown warnings down to (currently) 20
dpschen added the
kind/bug
 label 2022-01-05 10:06:55 +00:00
konrad was assigned by dpschen 2022-01-05 10:06:55 +00:00
dpschen force-pushed feature/fix-some-typescript-warnings from d4acecb4c2 to 4dda00dc8f 2022-01-05 10:07:33 +00:00 Compare
frederick commented 2022-01-05 10:16:08 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1304-featurefix-some-typescript-warnings--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1304-featurefix-some-typescript-warnings--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/fix-some-typescript-warnings from 4dda00dc8f to 1dbccb6c3e 2022-01-05 12:35:10 +00:00 Compare
konrad approved these changes 2022-01-05 14:26:11 +00:00
konrad left a comment
Owner

Looks good to me, should be good to merge once the conflicts are resolved.

Looks good to me, should be good to merge once the conflicts are resolved.
dpschen force-pushed feature/fix-some-typescript-warnings from 1dbccb6c3e to 49955eb03a 2022-01-05 15:17:30 +00:00 Compare
dpschen merged commit 49955eb03a into main 2022-01-05 15:45:55 +00:00
dpschen deleted branch feature/fix-some-typescript-warnings 2022-01-05 15:45:55 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1304
No description provided.
Delete Branch "dpschen/frontend:feature/fix-some-typescript-warnings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?