vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

chore: improve @/message action type #3209

Merged
konrad merged 1 commits from WofWca/frontend:types into main 2023-03-08 09:52:04 +00:00
Conversation 1 Commits 1 Files Changed 2 +9 -3
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/message/index.ts
View File

@ -17,7 +17,12 @@ export function getErrorText(r): string {
return data?.message || r.message
}
export function error(e, actions = []) {
export interface Action {
title: string,
callback: () => void,
}
export function error(e, actions: Action[] = []) {
notify({
type: 'error',
title: i18n.global.t('error.error'),
@ -26,7 +31,7 @@ export function error(e, actions = []) {
})
}
export function success(e, actions = []) {
export function success(e, actions: Action[] = []) {
notify({
type: 'success',
title: i18n.global.t('error.success'),

3
src/views/tasks/TaskDetailView.vue
View File

@ -496,6 +496,7 @@ import {useKanbanStore} from '@/stores/kanban'
import {useTitle} from '@/composables/useTitle'
import {success} from '@/message'
import type {Action as MessageAction} from '@/message'
const props = defineProps({
taskId: {
@ -728,7 +729,7 @@ async function saveTask(args?: {
Object.assign(task, newTask)
setActiveFields()
WofWca marked this conversation as resolved
konrad commented 2023-03-08 09:26:31 +00:00
Review
Copy Link

Why not export the

Why not export the
WofWca commented 2023-03-08 09:28:16 +00:00
Review
Copy Link

This looks simpler to me, easier to change and understand.

This looks simpler to me, easier to change and understand.
konrad commented 2023-03-08 09:32:48 +00:00
Review
Copy Link

whoops sorry, looks like my comment was cut off.

I meant to say: Why not export the new Action type and use that here?

whoops sorry, looks like my comment was cut off. I meant to say: Why not export the new `Action` type and use that here?
WofWca commented 2023-03-08 09:34:43 +00:00
Review
Copy Link

Yeah, I got what you mean.

Yeah, I got what you mean.
konrad commented 2023-03-08 09:36:36 +00:00
Review
Copy Link

I know how this does the same thing but it took me longer to understand. Can you still change it?

I know how this does the same thing but it took me longer to understand. Can you still change it?
let actions = []
let actions: MessageAction[] = []
if (undoCallback !== null) {
actions = [{
title: 'Undo',