vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

chore(deps): update pnpm to v8 #3317

Merged
konrad merged 1 commits from renovate/pnpm-8.x into main 2023-04-12 05:57:17 +00:00
Conversation 14 Commits 1 Files Changed 1 +1 -1
renovate commented 2023-03-28 09:05:15 +00:00
Member
Copy Link

This PR contains the following updates:

Package Type Update Change
pnpm (source) packageManager major 7.32.0 -> 8.2.0

Release Notes

pnpm/pnpm

v8.2.0

Compare Source

Minor Changes

  • Allow env variables to be specified with default values in .npmrc. This is a convention used by Yarn too.
    Using ${NAME-fallback} will return fallback if NAME isn't set. ${NAME:-fallback} will return fallback if NAME isn't set, or is an empty string #​6018.

Patch Changes

  • Add -g to mismatch registries error info when original command has -g option #​6224.
  • Don't fail with EBUSY error when trying to copy a file from the store #​6201
  • pnpm config get <key> should print boolean values #​6360
  • Don't print an info message about linked dependencies if they are real linked dependencies specified via the link: protocol in package.json #​6372

Our Gold Sponsors

Our Silver Sponsors

v8.1.1

Compare Source

Patch Changes

  • Repeat installation should work on a project that has a dependency with parentheses in the scope name #​6348.
  • Error summary should be reported as expected.
  • Update @yarnpkg/shell to fix issues in the shell emulator #​6320.
  • Installation should not fail when there is a local dependency in a directory that starts with the @ character #​6332.
  • Registries are now passed to the preResolution hook.

Our Gold Sponsors

Our Silver Sponsors

v8.1.0

Compare Source

Minor Changes

  • A new setting has been added called dedupe-direct-deps, which is disabled by default. When set to true, dependencies that are already symlinked to the root node_modules directory of the workspace will not be symlinked to subproject node_modules directories. This feature was enabled by default in v8.0.0 but caused issues, so it's best to disable it by default #​6299.
  • Add ignore-workspace-cycles to silence workspace cycle warning #​6308.

Patch Changes

  • Print the right lowest supported Node.js version in the error message, when pnpm is executed with an old Node.js version #​6297.
  • Improve the outdated lockfile error message #​6304.

Our Gold Sponsors

Our Silver Sponsors

v8.0.0

Compare Source

We are excited to announce the latest release of pnpm! To install it, check the installation page.

image

Major Changes

Node.js 14 Support Discontinued

If you still require Node.js 14, don't worry. We ship pnpm bundled with Node.js. This means that regardless of which Node.js version you've installed, pnpm will operate using the necessary Node.js runtime. For this to work you need to install pnpm either using the standalone script or install the @pnpm/exe package.

Configuration Updates

Most of the configuration changes are related to peer dependencies. Most of these settings were implemented long ago, and we recommended them to users encountering peer dependency issues. The recently added dedupe-peer-dependents resolved many such problems. With these new defaults, pnpm will face significantly fewer issues during migration from other package managers.

Lockfile Modifications
  • Lockfile v6 is adopted. This new format improves the readability of the lockfile by removing hashes from package IDs. It also has some rearrangement of fields in the importers section. The new pnpm-lock.yaml file is more resistant to git merge conflicts!
  • The registry field is removed from the resolution object in pnpm-lock.yaml.
  • A lockfile is generated even for projects with no dependencies.
Other Changes
  • When there's a files field in the package.json, only the files that are listed in it will be deployed. The same logic is applied when injecting packages. This behaviour can be changed by setting the deploy-all-files setting to true (Related issue #​5911).
  • Direct dependencies are deduped. If a dependency is present in both a project and the workspace root, it will only be linked to the workspace root.

Migration Instructions

Before updating pnpm to v8 in your CI, regenerate your pnpm-lock.yaml. To upgrade your lockfile, run pnpm install and commit the changes. Existing dependencies will not be updated; however, due to configuration changes in pnpm v8, some missing peer dependencies may be added to the lockfile and some packages may get deduplicated.

You can commit the new lockfile even before upgrading Node.js in the CI, as pnpm v7 already supports the new lockfile format.

pnpm v7 Support

pnpm v7 will likely not receive any new features, but it will continue to get bug fixes for a few months and vulnerability fixes for at least a year.

Our Gold Sponsors

Our Silver Sponsors

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pnpm](https://pnpm.io) ([source](https://github.com/pnpm/pnpm)) | packageManager | major | [`7.32.0` -> `8.2.0`](https://renovatebot.com/diffs/npm/pnpm/7.32.0/8.2.0) | --- ### Release Notes <details> <summary>pnpm/pnpm</summary> ### [`v8.2.0`](https://github.com/pnpm/pnpm/releases/tag/v8.2.0) [Compare Source](https://github.com/pnpm/pnpm/compare/v8.1.1...v8.2.0) #### Minor Changes - Allow env variables to be specified with default values in `.npmrc`. This is a convention used by Yarn too. Using `${NAME-fallback}` will return `fallback` if `NAME` isn't set. `${NAME:-fallback}` will return `fallback` if `NAME` isn't set, or is an empty string [#&#8203;6018](https://github.com/pnpm/pnpm/issues/6018). #### Patch Changes - Add `-g` to mismatch registries error info when original command has `-g` option [#&#8203;6224](https://github.com/pnpm/pnpm/issues/6224). - Don't fail with EBUSY error when trying to copy a file from the store [#&#8203;6201](https://github.com/pnpm/pnpm/issues/6201) - `pnpm config get <key>` should print boolean values [#&#8203;6360](https://github.com/pnpm/pnpm/issues/6360) - Don't print an info message about linked dependencies if they are real linked dependencies specified via the `link:` protocol in `package.json` [#&#8203;6372](https://github.com/pnpm/pnpm/issues/6372) #### Our Gold Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://pnpm.io/img/users/bit.svg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/novu.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/novu_light.svg" /> <img src="https://pnpm.io/img/users/novu.svg" width="180" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/prisma.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/prisma_light.svg" /> <img src="https://pnpm.io/img/users/prisma.svg" width="180" /> </picture> </a> </td> <td align="center" valign="middle"> <a href="https://www.flightcontrol.dev/?ref=pnpm" target="_blank"><img src="https://pnpm.io/img/users/flightcontrol.png" width="240"></a> </td> </tr> </tbody> </table> #### Our Silver Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <img src="https://pnpm.io/img/users/leniolabs.jpg" width="80"> </a> </td> <td align="center" valign="middle"> <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/vercel.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/vercel_light.svg" /> <img src="https://pnpm.io/img/users/vercel.svg" width="180" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://depot.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/depot.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/depot_light.svg" /> <img src="https://pnpm.io/img/users/depot.svg" width="200" /> </picture> </a> </td> <td align="center" valign="middle"> <a href="https://moonrepo.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/moonrepo.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/moonrepo_light.svg" /> <img src="https://pnpm.io/img/users/moonrepo.svg" width="200" /> </picture> </a> </td> </tr> </tbody> </table> ### [`v8.1.1`](https://github.com/pnpm/pnpm/releases/tag/v8.1.1) [Compare Source](https://github.com/pnpm/pnpm/compare/v8.1.0...v8.1.1) #### Patch Changes - Repeat installation should work on a project that has a dependency with parentheses in the scope name [#&#8203;6348](https://github.com/pnpm/pnpm/issues/6348). - Error summary should be reported as expected. - Update `@yarnpkg/shell` to fix issues in the shell emulator [#&#8203;6320](https://github.com/pnpm/pnpm/issues/6320). - Installation should not fail when there is a local dependency in a directory that starts with the `@` character [#&#8203;6332](https://github.com/pnpm/pnpm/issues/6332). - Registries are now passed to the `preResolution` hook. #### Our Gold Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://pnpm.io/img/users/bit.svg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/novu.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/novu_light.svg" /> <img src="https://pnpm.io/img/users/novu.svg" width="180" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/prisma.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/prisma_light.svg" /> <img src="https://pnpm.io/img/users/prisma.svg" width="180" /> </picture> </a> </td> <td align="center" valign="middle"> <a href="https://www.flightcontrol.dev/?ref=pnpm" target="_blank"><img src="https://pnpm.io/img/users/flightcontrol.png" width="240"></a> </td> </tr> </tbody> </table> #### Our Silver Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <img src="https://pnpm.io/img/users/leniolabs.jpg" width="80"> </a> </td> <td align="center" valign="middle"> <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/vercel.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/vercel_light.svg" /> <img src="https://pnpm.io/img/users/vercel.svg" width="180" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://depot.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/depot.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/depot_light.svg" /> <img src="https://pnpm.io/img/users/depot.svg" width="200" /> </picture> </a> </td> <td align="center" valign="middle"> <a href="https://moonrepo.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/moonrepo.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/moonrepo_light.svg" /> <img src="https://pnpm.io/img/users/moonrepo.svg" width="200" /> </picture> </a> </td> </tr> </tbody> </table> ### [`v8.1.0`](https://github.com/pnpm/pnpm/releases/tag/v8.1.0) [Compare Source](https://github.com/pnpm/pnpm/compare/v8.0.0...v8.1.0) #### Minor Changes - A new setting has been added called `dedupe-direct-deps`, which is disabled by default. When set to `true`, dependencies that are already symlinked to the root `node_modules` directory of the workspace will not be symlinked to subproject `node_modules` directories. This feature was enabled by default in v8.0.0 but caused issues, so it's best to disable it by default [#&#8203;6299](https://github.com/pnpm/pnpm/issues/6299). - Add `ignore-workspace-cycles` to silence workspace cycle warning [#&#8203;6308](https://github.com/pnpm/pnpm/pull/6308). #### Patch Changes - Print the right lowest supported Node.js version in the error message, when pnpm is executed with an old Node.js version [#&#8203;6297](https://github.com/pnpm/pnpm/issues/6297). - Improve the outdated lockfile error message [#&#8203;6304](https://github.com/pnpm/pnpm/pull/6304). #### Our Gold Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://pnpm.io/img/users/bit.svg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/novu.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/novu_light.svg" /> <img src="https://pnpm.io/img/users/novu.svg" width="180" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/prisma.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/prisma_light.svg" /> <img src="https://pnpm.io/img/users/prisma.svg" width="180" /> </picture> </a> </td> <td align="center" valign="middle"> <a href="https://www.flightcontrol.dev/?ref=pnpm" target="_blank"><img src="https://pnpm.io/img/users/flightcontrol.png" width="240"></a> </td> </tr> </tbody> </table> #### Our Silver Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <img src="https://pnpm.io/img/users/leniolabs.jpg" width="80"> </a> </td> <td align="center" valign="middle"> <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/vercel.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/vercel_light.svg" /> <img src="https://pnpm.io/img/users/vercel.svg" width="180" /> </picture> </a> </td> <td align="center" valign="middle"> <a href="https://depot.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/depot.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/depot_light.svg" /> <img src="https://pnpm.io/img/users/depot.svg" width="200" /> </picture> </a> </td> </tr> </tbody> </table> ### [`v8.0.0`](https://github.com/pnpm/pnpm/releases/tag/v8.0.0) [Compare Source](https://github.com/pnpm/pnpm/compare/v7.32.0...v8.0.0) We are excited to announce the latest release of pnpm! To install it, check the [installation page](https://pnpm.io/installation). ![image](https://user-images.githubusercontent.com/1927579/228101984-4a6bf4e5-9e70-480f-bf3b-140288e8f81e.png) #### Major Changes ##### Node.js 14 Support Discontinued If you still require Node.js 14, don't worry. We ship pnpm bundled with Node.js. This means that regardless of which Node.js version you've installed, pnpm will operate using the necessary Node.js runtime. For this to work you need to install pnpm either using the [standalone script](https://pnpm.io/installation#using-a-standalone-script) or install the `@pnpm/exe` package. ##### Configuration Updates - [`auto-install-peers`](https://pnpm.io/npmrc#auto-install-peers): enabled by default. - [`dedupe-peer-dependents`](https://pnpm.io/npmrc#dedupe-peer-dependents): enabled by default. - [`resolve-peers-from-workspace-root`](https://pnpm.io/npmrc#resolve-peers-from-workspace-root): enabled by default. - [`save-workspace-protocol`](https://pnpm.io/npmrc#save-workspace-protocol): set to `rolling` by default. - [`resolution-mode`](https://pnpm.io/npmrc#resolution-mode): set to `lowest-direct` by default. - [`publishConfig.linkDirectory`](https://pnpm.io/package_json#publishconfiglinkdirectory): enabled by default. Most of the configuration changes are related to peer dependencies. Most of these settings were implemented long ago, and we recommended them to users encountering peer dependency issues. The recently added `dedupe-peer-dependents` resolved many such problems. With these new defaults, pnpm will face significantly fewer issues during migration from other package managers. ##### Lockfile Modifications - [Lockfile v6](https://github.com/pnpm/pnpm/pull/5810) is adopted. This new format improves the readability of the lockfile by removing hashes from package IDs. It also has some rearrangement of fields in the `importers` section. **The new `pnpm-lock.yaml` file is more resistant to git merge conflicts!** - The registry field is removed from the `resolution` object in `pnpm-lock.yaml`. - A lockfile is generated even for projects with no dependencies. ##### Other Changes - When there's a `files` field in the `package.json`, only the files that are listed in it will be [deployed](https://pnpm.io/cli/deploy). The same logic is applied when [injecting packages](https://pnpm.io/package_json#dependenciesmetainjected). This behaviour can be changed by setting the [`deploy-all-files`](https://pnpm.io/8.x/npmrc#deploy-all-files) setting to `true` (Related issue [#&#8203;5911](https://github.com/pnpm/pnpm/issues/5911)). - Direct dependencies are deduped. If a dependency is present in both a project and the workspace root, it will only be linked to the workspace root. #### Migration Instructions Before updating pnpm to v8 in your CI, regenerate your `pnpm-lock.yaml`. To upgrade your lockfile, run `pnpm install` and commit the changes. Existing dependencies will not be updated; however, due to configuration changes in pnpm v8, some missing peer dependencies may be added to the lockfile and some packages may get deduplicated. You can commit the new lockfile even before upgrading Node.js in the CI, as pnpm v7 already supports the new lockfile format. #### pnpm v7 Support pnpm v7 will likely not receive any new features, but it will continue to get bug fixes for a few months and vulnerability fixes for at least a year. #### Our Gold Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://pnpm.io/img/users/bit.svg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/novu.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/novu_light.svg" /> <img src="https://pnpm.io/img/users/novu.svg" width="180" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/prisma.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/prisma_light.svg" /> <img src="https://pnpm.io/img/users/prisma.svg" width="180" /> </picture> </a> </td> <td align="center" valign="middle"> <a href="https://www.flightcontrol.dev/?ref=pnpm" target="_blank"><img src="https://pnpm.io/img/users/flightcontrol.png" width="240"></a> </td> </tr> </tbody> </table> #### Our Silver Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <img src="https://pnpm.io/img/users/leniolabs.jpg" width="80"> </a> </td> <td align="center" valign="middle"> <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/vercel.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/vercel_light.svg" /> <img src="https://pnpm.io/img/users/vercel.svg" width="180" /> </picture> </a> </td> <td align="center" valign="middle"> <a href="https://depot.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/depot.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/depot_light.svg" /> <img src="https://pnpm.io/img/users/depot.svg" width="200" /> </picture> </a> </td> </tr> </tbody> </table> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTcuMCIsInVwZGF0ZWRJblZlciI6IjM1LjI0LjYifQ==-->
renovate added the
dependencies
 label 2023-03-28 09:05:15 +00:00
frederick commented 2023-03-28 09:10:20 +00:00
Member
Copy Link

Hi renovate!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3317-renovate-pnpm-8-x--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi renovate! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3317-renovate-pnpm-8-x--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen commented 2023-03-28 09:31:16 +00:00
Member
Copy Link

Sweet! I guess as long as this installs it should be fine!

Sweet! I guess as long as this installs it should be fine!
dpschen requested review from konrad 2023-03-28 09:33:05 +00:00
konrad was assigned by dpschen 2023-03-28 09:33:10 +00:00
konrad commented 2023-03-28 09:50:56 +00:00
Owner
Copy Link

We need to make sure the nix flake, ci and docker images all use pnpm 8 in that case, not sure if that's already the case?

We need to make sure the nix flake, ci and docker images all use pnpm 8 in that case, not sure if that's already the case?
dpschen commented 2023-03-28 10:11:03 +00:00
Member
Copy Link

We need to make sure the nix flake, ci and docker images all use pnpm 8 in that case, not sure if that's already the case?

True!

> We need to make sure the nix flake, ci and docker images all use pnpm 8 in that case, not sure if that's already the case? True!
renovate force-pushed renovate/pnpm-8.x from acb3ccb629 to c1ba3a4ef2 2023-03-28 11:05:15 +00:00 Compare
renovate force-pushed renovate/pnpm-8.x from c1ba3a4ef2 to c3ca11b91a 2023-03-28 13:05:10 +00:00 Compare
renovate force-pushed renovate/pnpm-8.x from c3ca11b91a to e707c16fee 2023-03-28 15:05:32 +00:00 Compare
renovate force-pushed renovate/pnpm-8.x from e707c16fee to 2f8dd5a3d5 2023-03-28 20:05:15 +00:00 Compare
renovate force-pushed renovate/pnpm-8.x from 2f8dd5a3d5 to 2b13df795d 2023-03-29 08:05:27 +00:00 Compare
dpschen commented 2023-03-29 11:37:45 +00:00
Member
Copy Link

I created a pull request to prepare for pnpm 8. If we wait for a bit after merging that all active branches should have rebased from main / adapted the new lockfile format, which would make migration to pnpm 8 easier.

I created a [pull request to prepare for pnpm 8](https://kolaente.dev/vikunja/frontend/pulls/3331). If we wait for a bit after merging that all active branches should have rebased from main / adapted the new lockfile format, which would make migration to pnpm 8 easier.
dpschen added a new dependency 2023-03-29 11:38:02 +00:00
#3331 feat: prepare for pnpm 8
dpschen commented 2023-03-29 11:41:34 +00:00
Member
Copy Link

TODO

  • Remove .npmrc changes from cb8cbc22dd
  • Adjust nix flake to use pnpm 8
  • Adjust ci and docker images to use pnpm 8
# TODO - [ ] Remove `.npmrc` changes from https://kolaente.dev/vikunja/frontend/commit/cb8cbc22dd24c12e5ccf5e52985340c823b74822 - [ ] Adjust nix flake to use pnpm 8 - [x] Adjust ci and docker images to use pnpm 8
konrad commented 2023-03-29 11:42:39 +00:00
Owner
Copy Link

For the nix flake update we need to wait until pnpm 8 landed in nixos.

For the nix flake update we need to wait until pnpm 8 landed in nixos.
✅ 1
konrad commented 2023-03-29 11:42:52 +00:00
Owner
Copy Link

The CI and the docker image use the same image.

The CI and the docker image use the same image.
✅ 1
dpschen commented 2023-03-29 11:44:52 +00:00
Member
Copy Link

The CI and the docker image use the same image.

Adjusted the todo accordingly

> The CI and the docker image use the same image. Adjusted the todo accordingly
dpschen force-pushed renovate/pnpm-8.x from 2b13df795d to dfbbf5c346 2023-03-29 11:53:05 +00:00 Compare
konrad commented 2023-03-29 11:53:27 +00:00
Owner
Copy Link

Looks like the docker images are already up to date:

$ docker run -it --entrypoint sh node:18-alpine
/ # corepack enable
/ # pnpm --version
8.0.0
Looks like the docker images are already up to date: ``` $ docker run -it --entrypoint sh node:18-alpine / # corepack enable / # pnpm --version 8.0.0 ```
👍 1
konrad commented 2023-03-29 11:54:14 +00:00
Owner
Copy Link

This failure is interesting though: https://drone.kolaente.de/vikunja/frontend/13210/1/3

 ERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE  Cannot perform a frozen installation because the lockfile needs updates


Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile"
This failure is interesting though: https://drone.kolaente.de/vikunja/frontend/13210/1/3 ```  ERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE  Cannot perform a frozen installation because the lockfile needs updates Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile"
dpschen force-pushed renovate/pnpm-8.x from dfbbf5c346 to a66703fe7d 2023-03-29 11:55:52 +00:00 Compare
dpschen commented 2023-03-29 11:58:21 +00:00
Member
Copy Link

This failure is interesting though: https://drone.kolaente.de/vikunja/frontend/13210/1/3

 ERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE  Cannot perform a frozen installation because the lockfile needs updates


Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile"

No. I didn't rebase on top of the lockfile change branch. That's why the other branch needs to be merged first.

> This failure is interesting though: https://drone.kolaente.de/vikunja/frontend/13210/1/3 > > ``` >  ERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE  Cannot perform a frozen installation because the lockfile needs updates > > > Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile" No. I didn't rebase on top of the lockfile change branch. That's why the other branch needs to be merged first.
👍 1
dpschen commented 2023-03-29 11:58:48 +00:00
Member
Copy Link

We should wait for a while for the most active PRs to rebase with the new lockfile.

We should wait for a while for the most active PRs to rebase with the new lockfile.
👍 1
renovate force-pushed renovate/pnpm-8.x from a66703fe7d to ac3744f399 2023-03-29 16:04:17 +00:00 Compare
dpschen changed title from chore(deps): update pnpm to v8 to wip: chore(deps): update pnpm to v8 2023-03-29 16:50:32 +00:00
dpschen added the due date 2023-04-12 2023-03-29 16:51:00 +00:00
renovate changed title from wip: chore(deps): update pnpm to v8 to chore(deps): update pnpm to v8 2023-03-29 17:03:48 +00:00
renovate force-pushed renovate/pnpm-8.x from ac3744f399 to a1f8b7bf75 2023-03-29 23:04:25 +00:00 Compare
renovate force-pushed renovate/pnpm-8.x from a1f8b7bf75 to 42880176bd 2023-04-04 01:04:49 +00:00 Compare
renovate force-pushed renovate/pnpm-8.x from 42880176bd to 5bcbfa5664 2023-04-04 08:04:32 +00:00 Compare
dpschen changed title from chore(deps): update pnpm to v8 to wip: chore(deps): update pnpm to v8 2023-04-05 11:52:38 +00:00
renovate changed title from wip: chore(deps): update pnpm to v8 to chore(deps): update pnpm to v8 2023-04-06 09:06:57 +00:00
renovate force-pushed renovate/pnpm-8.x from 5bcbfa5664 to 55cd2aa07d 2023-04-10 00:05:57 +00:00 Compare
renovate force-pushed renovate/pnpm-8.x from 55cd2aa07d to 1d155b4a05 2023-04-10 12:05:35 +00:00 Compare
dpschen commented 2023-04-11 22:08:39 +00:00
Member
Copy Link

I guess we can merge now. Didn't really update the other branches – but also didn't have any probs with the new format.

I guess we can merge now. Didn't really update the other branches – but also didn't have any probs with the new format.
renovate force-pushed renovate/pnpm-8.x from 1d155b4a05 to c938f31935 2023-04-11 23:05:52 +00:00 Compare
konrad merged commit c938f31935 into main 2023-04-12 05:57:17 +00:00
konrad deleted branch renovate/pnpm-8.x 2023-04-12 05:57:17 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
4 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2023-04-12

Depends on
#3331 feat: prepare for pnpm 8
vikunja/frontend
Reference: vikunja/frontend#3317
No description provided.
Delete Branch "renovate/pnpm-8.x"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?