vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: prepare for pnpm 8 #3331

Merged
konrad merged 1 commits from dpschen/frontend:feature/prepare-pnpm8 into main 2023-03-29 12:02:36 +00:00
Conversation 10 Commits 1 Files Changed 2 +2690 -2945
dpschen commented 2023-03-29 11:35:33 +00:00
Member
Copy Link

By commiting the new lockfile format before using pnpm 8 we can improve the migration process.

Related: #3317

By commiting the new lockfile format before using pnpm 8 we can improve the migration process. Related: https://kolaente.dev/vikunja/frontend/pulls/3317
dpschen added the
kind/feature
changes requested
area/internal-code
 labels 2023-03-29 11:35:33 +00:00
dpschen requested review from konrad 2023-03-29 11:35:38 +00:00
konrad was assigned by dpschen 2023-03-29 11:35:43 +00:00
dpschen commented 2023-03-29 11:36:07 +00:00
Author
Member
Copy Link

Note: the new lockfile format and the settings here should all already be compatible with pnpm 7.

Note: the new lockfile format and the settings here should all already be compatible with pnpm 7.
dpschen added a new dependency 2023-03-29 11:38:02 +00:00
#3317 chore(deps): update pnpm to v8
frederick commented 2023-03-29 11:40:10 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3331-feature-prepare-pnpm8--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3331-feature-prepare-pnpm8--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen changed title from feat: prepare for pnpm 8 to wip: feat: prepare for pnpm 8 2023-03-29 11:44:00 +00:00
konrad commented 2023-03-29 11:44:34 +00:00
Owner
Copy Link

pnpm told me

 WARN  Ignoring broken lockfile at /home/konrad/www/vikunja/frontend: Lockfile /home/konrad/www/vikunja/frontend/pnpm-lock.yaml not compatible with current pnpm

That's probably due to the old pnpm I use. Can you rebase on main which has the updated nix flake with the newer pnpm?

Since which version is the new lockfile format supported?

pnpm told me ```  WARN  Ignoring broken lockfile at /home/konrad/www/vikunja/frontend: Lockfile /home/konrad/www/vikunja/frontend/pnpm-lock.yaml not compatible with current pnpm ``` That's probably due to the old pnpm I use. Can you rebase on main which has the updated nix flake with the newer pnpm? Since which version is the new lockfile format supported?
dpschen force-pushed feature/prepare-pnpm8 from cb8cbc22dd to eb8972ee50 2023-03-29 11:45:56 +00:00 Compare
dpschen force-pushed feature/prepare-pnpm8 from eb8972ee50 to 3f53d6d35c 2023-03-29 11:46:12 +00:00 Compare
dpschen changed title from wip: feat: prepare for pnpm 8 to feat: prepare for pnpm 8 2023-03-29 11:46:39 +00:00
dpschen commented 2023-03-29 11:50:09 +00:00
Author
Member
Copy Link

pnpm told me

 WARN  Ignoring broken lockfile at /home/konrad/www/vikunja/frontend: Lockfile /home/konrad/www/vikunja/frontend/pnpm-lock.yaml not compatible with current pnpm

That's probably due to the old pnpm I use. Can you rebase on main which has the updated nix flake with the newer pnpm?

Doing now!

Since which version is the new lockfile format supported?

Seems like since version v7.24.0, see: https://pnpm.io/7.x/npmrc#use-lockfile-v6

> pnpm told me > > ``` >  WARN  Ignoring broken lockfile at /home/konrad/www/vikunja/frontend: Lockfile /home/konrad/www/vikunja/frontend/pnpm-lock.yaml not compatible with current pnpm > ``` > > That's probably due to the old pnpm I use. Can you rebase on main which has the updated nix flake with the newer pnpm? Doing now! > Since which version is the new lockfile format supported? Seems like since version v7.24.0, see: https://pnpm.io/7.x/npmrc#use-lockfile-v6
konrad commented 2023-03-29 11:51:15 +00:00
Owner
Copy Link

That seems to have worked.

That seems to have worked.
🎉 1
dpschen commented 2023-03-29 11:57:33 +00:00
Author
Member
Copy Link

Ok, so this can be merged?

Ok, so this can be merged?
konrad commented 2023-03-29 11:58:10 +00:00
Owner
Copy Link

Let me update renovate first.

Let me update renovate first.
👍 1
dpschen commented 2023-03-29 11:59:57 +00:00
Author
Member
Copy Link

Let me update renovate first.

Just to be clear: the changes in this branch should be compatible with the last few versions of pnpm@7

> Let me update renovate first. Just to be clear: the changes in this branch should be compatible with the last few versions of pnpm@7
konrad commented 2023-03-29 12:02:07 +00:00
Owner
Copy Link

Yes, but it's been a long while since I last updated renovate and we need to do it anyway for pnpm 8.

Yes, but it's been a long while since I last updated renovate and we need to do it anyway for pnpm 8.
👍 1
konrad commented 2023-03-29 12:02:16 +00:00
Owner
Copy Link

It is updated now, merging...

It is updated now, merging...
konrad merged commit 7d3b97d422 into main 2023-03-29 12:02:36 +00:00
konrad deleted branch feature/prepare-pnpm8 2023-03-29 12:02:37 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#3317 chore(deps): update pnpm to v8
vikunja/frontend
Reference: vikunja/frontend#3331
No description provided.
Delete Branch "dpschen/frontend:feature/prepare-pnpm8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?