feat: hide priority label for done tasks #825

konrad · 2021-10-04T19:59:54Z

konrad commented

2021-10-04 19:59:54 +00:00

Resolves #542

👍 1

dpschen was assigned by konrad

2021-10-04 19:59:59 +00:00

konrad reviewed 2021-10-04 20:00:28 +00:00

src/components/tasks/partials/priorityLabel.vue Outdated

						
				@ -42,0 +41,4 @@

					},

					computed: {

						priority() {

							return this.task.priority

konrad commented

2021-10-04 20:00:28 +00:00

@dpschen I'm not sure if this could cause mutation errors, what do you think?

dpschen commented

2021-10-04 20:15:48 +00:00

Doesn't look like it, since this computed just returns a deep value. Not sure if necessary though. You could just write task.priority in the template in this case.

Doesn't look like it, since this computed just returns a deep value. Not sure if necessary though. You could just write `task.priority` in the template in this case.

konrad commented

2021-10-04 20:36:03 +00:00

Added 👍 I was just being lazy 😅

konrad marked this conversation as resolved

dpschen reviewed 2021-10-04 20:16:55 +00:00

dpschen reviewed 2021-10-04 20:19:59 +00:00

src/components/tasks/partials/priorityLabel.vue Outdated

						
				@ -39,3 +35,4 @@

							type: Boolean,

							default: false,

						},

						task: {

dpschen commented

2021-10-04 20:19:59 +00:00

Instead of passing the whole task down I would just add done as an additional prop. This way there is no deep coupling between the task model and the priority label.

Instead of passing the whole task down I would just add `done` as an additional prop. This way there is no deep coupling between the task model and the priority label.

konrad commented

2021-10-04 20:40:51 +00:00

I thought about that initially but I think it makes a lot of sense the way you put it. Changed!

👍 1

konrad marked this conversation as resolved

konrad force-pushed feature/hide-priority-for-done-tasks from 8feb0b0c5b to 68e5a5fd8a

2021-10-04 20:40:18 +00:00

Compare

dpschen commented

2021-10-04 21:42:55 +00:00

Looks good (not allowed to approve)