vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: migration icons are not resolved properly #864

Merged
konrad merged 2 commits from fix/migration-icons into main 2021-10-26 20:21:20 +00:00
Conversation 4 Commits 2 Files Changed 10 +303 -345
konrad commented 2021-10-17 16:08:15 +00:00
Owner
Copy Link

It looks like the icons of third-party services are not resolved properly.

This is what it looks like currently:
image

I noticed that the structure returned from serviceIconSources only contains the urls but has no way of mapping the service to its logo. Changing that so that the logos can be accessed with the keys of their service didn't fix it.

@dpschen Could you look into this?

It looks like the icons of third-party services are not resolved properly. This is what it looks like currently: ![image](/attachments/b5d6ea36-75d7-4d4c-9961-5736f83c79d1) I noticed that the structure returned from `serviceIconSources` only contains the urls but has no way of mapping the service to its logo. Changing that so that the logos can be accessed with the keys of their service didn't fix it. @dpschen Could you look into this?
image.png
11 KiB
dpschen was assigned by konrad 2021-10-21 19:11:48 +00:00
dpschen force-pushed fix/migration-icons from a5aff7f4fd to 2dbcb72fac 2021-10-26 11:26:09 +00:00 Compare
dpschen commented 2021-10-26 12:23:25 +00:00
Member
Copy Link

@dpschen Could you look into this?

I think I fixed it. Might have gone a bit over board.
I tried to test everything, but might make sense to test everything again before merging. E.g. I didn't export in the test since that I don't have the api properly configured.

> @dpschen Could you look into this? I think I fixed it. Might have gone a bit over board. I tried to test everything, but might make sense to test everything again before merging. E.g. I didn't export in the test since that I don't have the api properly configured.
konrad was assigned by dpschen 2021-10-26 12:23:38 +00:00
dpschen removed their assignment 2021-10-26 12:23:45 +00:00
konrad commented 2021-10-26 18:14:29 +00:00
Author
Owner
Copy Link

Looks like this still does not work:

I had an old version - sorry for the noise. Works like it should.

~~Looks like this still does not work:~~ I had an old version - sorry for the noise. Works like it should.
image.png
23 KiB
image.png
konrad commented 2021-10-26 18:27:13 +00:00
Author
Owner
Copy Link

This should be centered:

image

And the class="migration-in-progress-container" looks like a bug...

This should be centered: ![image](/attachments/a7ed6403-3784-401b-8403-8da45d4d4920) And the `class="migration-in-progress-container"` looks like a bug...
image.png
36 KiB
konrad reviewed 2021-10-26 18:34:26 +00:00
konrad left a comment
Author
Owner

Looks great overall! Just the centering issue I mentioned earlier and this is ready to merge.

Looks great overall! Just the centering issue I mentioned earlier and this is ready to merge.
dpschen force-pushed fix/migration-icons from 913dbc8ac6 to 49ede9f2ad 2021-10-26 20:08:51 +00:00 Compare
dpschen commented 2021-10-26 20:09:48 +00:00
Member
Copy Link

This should be centered:

image

And the class="migration-in-progress-container" looks like a bug...

Fixed! Was the same issue.

> This should be centered: > > ![image](/attachments/a7ed6403-3784-401b-8403-8da45d4d4920) > > And the `class="migration-in-progress-container"` looks like a bug... Fixed! Was the same issue.
konrad merged commit e1a7fb4999 into main 2021-10-26 20:21:20 +00:00
konrad deleted branch fix/migration-icons 2021-10-26 20:21:20 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#864
No description provided.
Delete Branch "fix/migration-icons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?