vue3 #815
No reviewers
konrad
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
2 Participants
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#815
Loading…
Reference in New Issue
No description provided.
Delete Branch "vue3"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Things left to fix
TypeError: _ctx.currentList is nulland completly breaks when opening from kanbanUncaught (in promise) TypeError: i18n.setLocaleMessage is not a functionTypeError: this.$t is not a function(deprecation ATTR_ENUMERATED_COERCION) Enumerated attribute "spellcheck" with v-bind valuefalsewill render the value as-is instead of coercing the value to "true" in Vue 3. Always use explicit "true" or "false" values for enumerated attributes.User avatar uploadLooks like this is an issue with vue-advanced-cropper, nothing to fix hereMigration images are missingnot a vue 3 issues, see #864ccfa67298bto66648be6d5@ -5,6 +5,7 @@ trigger:branch:include:- main- vue3That should not be required since there's a PR open for that branch.
Done!
I think it's needed, because after 5c291530ab the pull request #819 didn't update anymore when trying a new setting.
I readded this.
@ -34,2 +49,4 @@color: '',lastChangeTimeout: null,defaultColors: DEFAULT_COLORS,colorListID: createRandomID(),What about using
this._uidhere?As far as I know it's still not endorsed: https://github.com/vuejs/vue/issues/5886#issuecomment-308625735
Fixed in
5c291530ab(other pull request)I see. We're using
this._uidin the editor, time to change that I guess.Added the helper to the editor aswell in
18d7ca0820@ -23,3 +23,3 @@"usernamePlaceholder": "z.B. frederick","email": "E-Mail-Adresse","emailPlaceholder": "z.B. frederic@vikunja.io","emailPlaceholder": "z.B. frederic{'@'}vikunja.io",That should be changed in Crowdin as it will get overridden when translations are updated.
What does that do actually?
Yes I know, I didn't want to change that as long as crowdin is also the source for the vue2 version since it would break there.
It's a really weird breaking change of vue-i18n v9: https://vue-i18n.intlify.dev/guide/migration/breaking.html#special-character-handling
mhh then that should go in the ci step that updates translations from crowdin: https://kolaente.dev/vikunja/frontend/src/branch/main/.drone.yml#L604
You mean patching this change during that step?
yup.
I'm not sure how to solve this. Can you help me with this?
The CI syncs the translations here - we would need to add a script there (maybe just using sed would work already) that replaces all
@with{'@'}in the newly synced files.Wouldn't that lead to multiple levels of nesting?
b79d238bdcSo wouldn't it produce something like this:
{'{'@'}'}?It wouldn't since the sync job always downloads a fresh copy from crowdin. And we could easily create a regex that pays attention to these kinds of things.
After second though, it's probably enough to change this in the en base translation and then in crowdin.
I think this makes it impossible to use the translation for the vue2 branch.
Yes, but I don't think that's a problem as all translations for that string will be invalidated when the change in the en translation file is synced to crowdin.
WIP: vue3to vue3