feat: add close task popup link #880

konrad · 2021-10-19T20:25:16Z

konrad commented

2021-10-19 20:25:16 +00:00

This PR adds a "Close this popup" button to the task detail view, above the "Done" button:

Resolves #737

This PR adds a "Close this popup" button to the task detail view, above the "Done" button: ![image](/attachments/e102c9c5-d623-4291-af28-b57a53227d9b) Resolves #737

image.png

5.9 KiB

konrad added 1 commit 2021-10-19 20:25:17 +00:00

continuous-integration/drone/pr Build is passing Details

992cec40e4

feat: add close task popup link

resolves #737

konrad referenced this pull request

2021-10-19 20:26:07 +00:00

Task Detailview: How it is meant to be "closed" (and order of menu) #1824

dpschen commented

2021-10-19 21:41:59 +00:00

I like the that this adds a label to the button.
Other than that can't we use just change this line to:

color: $black;

Then the same close button would be used for desktop and mobile. We could (and should) still add a label.

I like the that this adds a label to the button. Other than that can't we use just change [this line](https://kolaente.dev/vikunja/frontend/src/branch/main/src/views/tasks/TaskDetailViewModal.vue#L60) to: ```scss color: $black; ``` Then the same close button would be used for desktop and mobile. We could (and should) still add a label.

konrad commented

2021-10-20 19:01:30 +00:00

This a new button, not the same as the close icon that already exists. I think we should keep both but can't really make the close icon of the popup visible on mobile simply because the popup takes up all available space there. There simply isn't any space to show the close icon on mobile.

dpschen commented

2021-10-20 19:11:04 +00:00

Ahhh can it be that is just about when the task is opened in detail view not as a popup?

Because the change I proposed does work on mobile. But just where the task is opened as a popup. I never really understood why the task is opened as popup sometimes and sometimes not.

Ahhh can it be that is just about when the task is opened in detail view not as a popup? Because the change I proposed does work on mobile. But just where the task is opened as a popup. I never really understood why the task is opened as popup sometimes and sometimes not.

Screen Recording 2021-10-20 at 21.08.11.mov

1.3 MiB

konrad commented

2021-10-20 19:16:08 +00:00

No, this is actually only about when the task is opened as a popup. I didn't really think about mobile here tbh, only wanted to address the issue mentioned in the pr. Extending it to mobile so that you can see the close icon makes sense I think.

I never really understood why the task is opened as popup sometimes and sometimes not.

The popup was added later on when I first introduced Kanban. It didn't feel "right" to open a task from kanban in plain detail view.

No, this is actually only about when the task is opened as a popup. I didn't really think about mobile here tbh, only wanted to address the issue mentioned in the pr. Extending it to mobile so that you can see the close icon makes sense I think. > I never really understood why the task is opened as popup sometimes and sometimes not. The popup was added later on when I first introduced Kanban. It didn't feel "right" to open a task from kanban in plain detail view.

👍 1

dpschen commented

2021-10-20 19:26:33 +00:00

The popup was added later on when I first introduced Kanban. It didn't feel "right" to open a task from kanban in plain detail view.

Yes that makes sense :)

> The popup was added later on when I first introduced Kanban. It didn't feel "right" to open a task from kanban in plain detail view. Yes that makes sense :)

konrad added 1 commit 2021-10-21 18:48:54 +00:00